ClearKeyUtils.cpp: the 'empty' method should be used to check for emptiness instead of 'size'
Categories
(Developer Infrastructure :: Source Code Analysis, task)
Tracking
(firefox100 fixed)
Tracking | Status | |
---|---|---|
firefox100 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: tvaleev, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
Filling as a good first bug to learn workflows.
aKeyIDs.size()
should use .empty() instead
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html
Tutorials to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Assignee | ||
Comment 1•3 years ago
|
||
In ClearKeyUtils.cpp: the 'empty' method should be used to check
for emptiness instead of 'size'
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Just to remember how to contribute to Mozilla :)
Assignee | ||
Comment 4•3 years ago
|
||
@Sylvestre could you please recommend some new bug to continue?:)
Comment 5•3 years ago
|
||
bugherder |
Reporter | ||
Comment 6•3 years ago
|
||
Timur, interested to run:
https://bugzilla.mozilla.org/show_bug.cgi?id=1617532
on the whole tree?
Assignee | ||
Comment 7•3 years ago
|
||
Yes. Going to take care about it.
Updated•3 years ago
|
Description
•